Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch zynaddsubfx to submodule #3930

Merged
merged 2 commits into from Nov 3, 2017
Merged

Switch zynaddsubfx to submodule #3930

merged 2 commits into from Nov 3, 2017

Conversation

tresf
Copy link
Member

@tresf tresf commented Nov 1, 2017

plugins/zynaddsubfx contains a fork of the upstream 2.4.4. version with changes applied for integration to LMMS located at https://github.com/lmms/zynaddsubfx.

The contained plugins/zynaddsubfx/zynaddsubfx folder is redundant with the forked repo and should be removed to simplify and cleanup the codebase.

More discussion available here: LMMS/lmms.io#241

@tresf
Copy link
Member Author

tresf commented Nov 3, 2017

This is a trivial change and submodules are already mandated by the master branch. Merging.

@tresf tresf merged commit 9d317e1 into LMMS:master Nov 3, 2017
@tresf tresf deleted the zynsubmodule branch November 10, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant